Skip to content

faster byte_serialized_unchanged #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

faster byte_serialized_unchanged #1014

wants to merge 2 commits into from

Conversation

oriongonza
Copy link

@oriongonza oriongonza commented Dec 31, 2024 •
edited
Loading

This uses a precomputed table.
This abuses the neat trick that ascii fits inside a u128.
https://godbolt.org/z/sh5MejEo5

To check that this is right you just need to call this in a loop and check the results:

    for i in 0..=255 {
        let res = byte_serialized_unchanged(i);
        println!("{}: {res}", i as char);
    }
: false
: false
: false
: false
: false
: false
: false
: false
: false
        : false

: false

: false

: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
 false
: false
: false
: false
: false
 : false
!: false
": false
#: false
$: false
%: false
&: false
': false
(: false
): false
*: true
+: false
,: false
-: true
.: true
/: false
0: true
1: true
2: true
3: true
4: true
5: true
6: true
7: true
8: true
9: true
:: false
;: false
<: false
=: false
>: false
?: false
@: false
A: true
B: true
C: true
D: true
E: true
F: true
G: true
H: true
I: true
J: true
K: true
L: true
M: true
N: true
O: true
P: true
Q: true
R: true
S: true
T: true
U: true
V: true
W: true
X: true
Y: true
Z: true
[: false
\: false
]: false
^: false
_: true
`: false
a: true
b: true
c: true
d: true
e: true
f: true
g: true
h: true
i: true
j: true
k: true
l: true
m: true
n: true
o: true
p: true
q: true
r: true
s: true
t: true
u: true
v: true
w: true
x: true
y: true
z: true
{: false
|: false
}: false
~: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
: false
 : false
¡: false
¢: false
£: false
¤: false
¥: false
¦: false
§: false
¨: false
©: false
ª: false
«: false
¬: false
­: false
®: false
¯: false
°: false
±: false
²: false
³: false
´: false
µ: false
¶: false
·: false
¸: false
¹: false
º: false
»: false
¼: false
½: false
¾: false
¿: false
À: false
Á: false
Â: false
Ã: false
Ä: false
Å: false
Æ: false
Ç: false
È: false
É: false
Ê: false
Ë: false
Ì: false
Í: false
Î: false
Ï: false
Ð: false
Ñ: false
Ò: false
Ó: false
Ô: false
Õ: false
Ö: false
×: false
Ø: false
Ù: false
Ú: false
Û: false
Ü: false
Ý: false
Þ: false
ß: false
à: false
á: false
â: false
ã: false
ä: false
å: false
æ: false
ç: false
è: false
é: false
ê: false
ë: false
ì: false
í: false
î: false
ï: false
ð: false
ñ: false
ò: false
ó: false
ô: false
õ: false
ö: false
÷: false
ø: false
ù: false
ú: false
û: false
ü: false
ý: false
þ: false
ÿ: false

@oriongonza oriongonza force-pushed the faster_check branch 2 times, most recently from 9d3ad4f to c98773f Compare December 31, 2024 14:48
@oriongonza
Copy link
Author

Oh, this requires bumping the msrv

@hsivonen
Copy link
Collaborator

hsivonen commented Jan 3, 2025

It should be easy to write this as using a const function, which should make this work at least all the way back to Rust 1.57.

See

rust-url/idna/src/uts46.rs

Line 72 in 8a683ff

const fn glyphless_mask() -> u128 {
and

rust-url/idna/src/uts46.rs

Line 85 in 8a683ff

const GLYPHLESS_MASK: u128 = glyphless_mask();

@lucacasonato
Copy link
Collaborator

@dev-ardi Are you still interested in pursuing this with the suggestion @hsivonen mentioned?

@oriongonza
Copy link
Author

oops i forgor 💀

@lucacasonato
Update lib
c835f25 
Signed-off-by: Luca Casonato <[email protected]>
lucacasonato
lucacasonato approved these changes Apr 30, 2025
View reviewed changes
Copy link
Collaborator

@lucacasonato lucacasonato left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@codecov Codecov
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@84cf467). Learn more about missing BASE report.

Files with missing lines Patch % Lines
form_urlencoded/src/lib.rs 27.27% 8 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1014   +/-   ##
=======================================
  Coverage        ?   79.70%           
=======================================
  Files           ?       24           
  Lines           ?     4365           
  Branches        ?        0           
=======================================
  Hits            ?     3479           
  Misses          ?      886           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret left review comments

@Manishearth Manishearth Manishearth approved these changes

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oriongonza @hsivonen @lucacasonato @dsherret @Manishearth